Skip to content

Commit 1916e30

Browse files
author
Yosevu Kilonzo
committed
fix(tabs): selection indicator scroll overflow border
CSS-242
1 parent 25aa0a7 commit 1916e30

File tree

1 file changed

+40
-6
lines changed

1 file changed

+40
-6
lines changed

components/tabs/skin.css

Lines changed: 40 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,34 @@ governing permissions and limitations under the License.
1111
*/
1212

1313
.spectrum-Tabs {
14+
--spectrum-tabs-list-background-direction: top;
15+
1416
border-block-end-color: var(--spectrum-tabs-textonly-divider-background-color);
1517
}
1618

1719
.spectrum-Tabs--vertical {
20+
--spectrum-tabs-list-background-direction: right;
21+
1822
border-inline-start-color: var(--spectrum-tabs-vertical-textonly-divider-background-color);
1923
}
2024

2125
.spectrum-Tabs-selectionIndicator {
22-
background-color: var(--spectrum-tabs-textonly-tabitem-selection-indicator-background-color-selected);
26+
background: linear-gradient(
27+
to var(--spectrum-tabs-list-background-direction),
28+
var(--spectrum-tabs-textonly-tabitem-selection-indicator-background-color-selected) 0,
29+
var(--spectrum-tabs-textonly-tabitem-selection-indicator-background-color-selected) var(--spectrum-tabs-quiet-textonly-divider-size),
30+
transparent var(--spectrum-tabs-quiet-textonly-divider-size)
31+
);
2332
}
2433

2534
.spectrum-Tabs--emphasized {
2635
.spectrum-Tabs-selectionIndicator {
27-
background-color: var(--spectrum-tabs-emphasized-texticon-tabitem-selection-indicator-background-color-selected);
36+
background: linear-gradient(
37+
to var(--spectrum-tabs-list-background-direction),
38+
var(--spectrum-tabs-emphasized-texticon-tabitem-selection-indicator-background-color-selected) 0,
39+
var(--spectrum-tabs-emphasized-texticon-tabitem-selection-indicator-background-color-selected) var(--spectrum-tabs-quiet-textonly-divider-size),
40+
transparent var(--spectrum-tabs-quiet-textonly-divider-size)
41+
);
2842
}
2943
}
3044

@@ -88,12 +102,22 @@ governing permissions and limitations under the License.
88102
border-block-end-color: var(--spectrum-tabs-quiet-textonly-divider-background-color);
89103

90104
.spectrum-Tabs-selectionIndicator {
91-
background-color: var(--spectrum-tabs-quiet-textonly-tabitem-selection-indicator-background-color-selected);
105+
background: linear-gradient(
106+
to var(--spectrum-tabs-list-background-direction),
107+
var(--spectrum-tabs-quiet-textonly-tabitem-selection-indicator-background-color-selected) 0,
108+
var(--spectrum-tabs-quiet-textonly-tabitem-selection-indicator-background-color-selected) var(--spectrum-tabs-quiet-textonly-divider-size),
109+
transparent var(--spectrum-tabs-quiet-textonly-divider-size)
110+
);
92111
}
93112

94113
&.spectrum-Tabs--emphasized {
95114
.spectrum-Tabs-selectionIndicator {
96-
background-color: var(--spectrum-tabs-emphasized-texticon-tabitem-selection-indicator-background-color-selected);
115+
background: linear-gradient(
116+
to var(--spectrum-tabs-list-background-direction),
117+
var(--spectrum-tabs-textonly-tabitem-selection-indicator-background-color-selected) 0,
118+
var(--spectrum-tabs-textonly-tabitem-selection-indicator-background-color-selected) var(--spectrum-tabs-quiet-textonly-divider-size),
119+
transparent var(--spectrum-tabs-quiet-textonly-divider-size)
120+
);
97121
}
98122
}
99123
}
@@ -104,14 +128,24 @@ governing permissions and limitations under the License.
104128
border-inline-start-color: var(--spectrum-tabs-vertical-quiet-textonly-divider-background-color);
105129

106130
.spectrum-Tabs-selectionIndicator {
107-
background-color: var(--spectrum-tabs-vertical-textonly-tabitem-selection-indicator-background-color-selected);
131+
background: linear-gradient(
132+
to var(--spectrum-tabs-list-background-direction),
133+
var(--spectrum-tabs-vertical-textonly-tabitem-selection-indicator-background-color-selected) 0,
134+
var(--spectrum-tabs-vertical-textonly-tabitem-selection-indicator-background-color-selected) var(--spectrum-tabs-quiet-textonly-divider-size),
135+
transparent var(--spectrum-tabs-quiet-textonly-divider-size)
136+
);
108137
}
109138
}
110139

111140
&.spectrum-Tabs--emphasized {
112141
border-inline-start-color: var(--spectrum-tabs-emphasized-textonly-divider-background-color);
113142
.spectrum-Tabs-selectionIndicator {
114-
background-color: var(--spectrum-tabs-emphasized-texticon-tabitem-selection-indicator-background-color-selected);
143+
background: linear-gradient(
144+
to var(--spectrum-tabs-list-background-direction),
145+
var(--spectrum-tabs-emphasized-texticon-tabitem-selection-indicator-background-color-selected) 0,
146+
var(--spectrum-tabs-emphasized-texticon-tabitem-selection-indicator-background-color-selected) var(--spectrum-tabs-quiet-textonly-divider-size),
147+
transparent var(--spectrum-tabs-quiet-textonly-divider-size)
148+
);
115149
}
116150
}
117151
}

0 commit comments

Comments
 (0)