Skip to content

Commit 157438c

Browse files
committed
fix(button): restore original 1.2 line-height
The new unitless line-height values are not going to work until the component-top-to-text and component-bottom-to-text are also updated. Which will come along with the new variable font update.
1 parent e8ad19f commit 157438c

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

components/button/index.css

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ governing permissions and limitations under the License.
2525
--spectrum-button-border-radius: calc(var(--spectrum-button-height) / 2);
2626
--spectrum-button-border-width: var(--spectrum-border-width-200);
2727

28-
/* @todo set line-height using font size specific line-height tokens when they are finalized. */
29-
--spectrum-button-line-height: 1.285714;
28+
/* @todo set line-height using font size specific line-height tokens when they are finalized along with the new variable font. */
29+
--spectrum-button-line-height: 1.2;
3030
--spectrum-button-font-weight: var(--spectrum-bold-font-weight);
3131
--spectrum-button-font-size: var(--spectrum-font-size-100);
3232

@@ -48,8 +48,6 @@ governing permissions and limitations under the License.
4848
--spectrum-button-min-width: calc(var(--spectrum-component-height-75) * var(--spectrum-button-minimum-width-multiplier));
4949
--spectrum-button-height: var(--spectrum-component-height-75);
5050

51-
/* @todo set line-height using font size specific line-height tokens when they are finalized. */
52-
--spectrum-button-line-height: 1.333333;
5351
--spectrum-button-font-size: var(--spectrum-font-size-75);
5452

5553
--spectrum-button-edge-to-visual: calc(var(--spectrum-component-pill-edge-to-visual-75) - var(--spectrum-button-border-width));
@@ -70,8 +68,6 @@ governing permissions and limitations under the License.
7068
--spectrum-button-min-width: calc(var(--spectrum-component-height-200) * var(--spectrum-button-minimum-width-multiplier));
7169
--spectrum-button-height: var(--spectrum-component-height-200);
7270

73-
/* @todo set line-height using font size specific line-height tokens when they are finalized. */
74-
--spectrum-button-line-height: 1.25;
7571
--spectrum-button-font-size: var(--spectrum-font-size-200);
7672

7773
--spectrum-button-edge-to-visual: calc(var(--spectrum-component-pill-edge-to-visual-200) - var(--spectrum-button-border-width));
@@ -88,8 +84,6 @@ governing permissions and limitations under the License.
8884
--spectrum-button-min-width: calc(var(--spectrum-component-height-300) * var(--spectrum-button-minimum-width-multiplier));
8985
--spectrum-button-height: var(--spectrum-component-height-300);
9086

91-
/* @todo set line-height using font size specific line-height tokens when they are finalized. */
92-
--spectrum-button-line-height: 1.333333;
9387
--spectrum-button-font-size: var(--spectrum-font-size-300);
9488

9589
--spectrum-button-edge-to-visual: calc(var(--spectrum-component-pill-edge-to-visual-300) - var(--spectrum-button-border-width));

0 commit comments

Comments
 (0)