Skip to content

Commit 0331dae

Browse files
RajdeepcRajdeep Chandrapfulton
authored
feat(overlay)!: migrate to spectrum-tokens (#2165)
BREAKING CHANGE: migrates Overlay to use `@adobe/spectrum-tokens` * feat(overlay): migrate to use spectrum-tokens BREAKING CHANGE: migrate overlay to use spectrum tokens * chore(tokens): add custom tokens to overlay component * docs: regenerate mods --------- Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com> Co-authored-by: Patrick Fulton <pfulton@adobe.com>
1 parent 7e9695d commit 0331dae

File tree

4 files changed

+25
-20
lines changed

4 files changed

+25
-20
lines changed

components/commons/metadata/mods.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
| Modifiable Custom Properties |
2-
| ------------------------------ |
3-
| `--mod-animation-duration-100` |
4-
| `--mod-focus-indicator-gap` |
5-
| `--mod-line-height-100` |
6-
| `--mod-sans-font-family-stack` |
1+
| Modifiable Custom Properties |
2+
| ----------------------------------------- |
3+
| `--mod-overlay-animation-distance` |
4+
| `--mod-overlay-animation-duration-opened` |

components/commons/overlay-coretokens.css

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ governing permissions and limitations under the License.
1414
/* TODO: replace with core tokens */
1515
--spectrum-overlay-animation-distance: 6px;
1616
--spectrum-overlay-animation-duration: var(--spectrum-animation-duration-100);
17+
--spectrum-overlay-animation-duration-opened: var(--spectrum-animation-duration-0);
1718

1819
visibility: hidden;
1920

@@ -29,26 +30,26 @@ governing permissions and limitations under the License.
2930
%spectrum-overlay--open {
3031
visibility: visible;
3132
opacity: 1;
32-
transition-delay: 0ms;
33+
transition-delay: var(--mod-overlay-animation-duration-opened, var(--spectrum-overlay-animation-duration-opened));
3334
pointer-events: auto;
3435
}
3536

3637
%spectrum-overlay--bottom--open {
3738
--spectrum-overlay-animation-distance: 6px;
38-
transform: translateY(var(--spectrum-overlay-animation-distance));
39+
transform: translateY(var(--mod-overlay-animation-distance, var(--spectrum-overlay-animation-distance)));
3940
}
4041

4142
%spectrum-overlay--top--open {
4243
--spectrum-overlay-animation-distance: 6px;
43-
transform: translateY(calc(-1 * var(--spectrum-overlay-animation-distance)));
44+
transform: translateY(calc(-1 * var(--mod-overlay-animation-distance, var(--spectrum-overlay-animation-distance))));
4445
}
4546

4647
%spectrum-overlay--right--open {
4748
--spectrum-overlay-animation-distance: 6px;
48-
transform: translateX(var(--spectrum-overlay-animation-distance));
49+
transform: translateX(var(--mod-overlay-animation-distance, var(--spectrum-overlay-animation-distance)));
4950
}
5051

5152
%spectrum-overlay--left--open {
5253
--spectrum-overlay-animation-distance: 6px;
53-
transform: translateX(calc(-1 * var(--spectrum-overlay-animation-distance)));
54+
transform: translateX(calc(-1 * var(--mod-overlay-animation-distance, var(--spectrum-overlay-animation-distance))));
5455
}

components/overlay/index.css

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,17 @@ governing permissions and limitations under the License.
1010
*/
1111

1212
%spectrum-overlay {
13-
--spectrum-overlay-animation-distance: var(--spectrum-picker-m-texticon-popover-offset-y);
13+
--spectrum-overlay-animation-distance: 6px;
14+
--spectrum-overlay-animation-duration: var(--spectrum-animation-duration-100);
15+
--spectrum-overlay-animation-duration-opened: var(--spectrum-animation-duration-0);
1416

1517
visibility: hidden;
1618

1719
opacity: 0;
1820

19-
transition: transform var(--spectrum-global-animation-duration-100) ease-in-out,
20-
opacity var(--spectrum-global-animation-duration-100) ease-in-out,
21-
visibility 0ms linear var(--spectrum-global-animation-duration-100);
21+
transition: transform var(--spectrum-overlay-animation-duration) ease-in-out,
22+
opacity var(--spectrum-overlay-animation-duration) ease-in-out,
23+
visibility 0ms linear var(--spectrum-overlay-animation-duration);
2224

2325
pointer-events: none;
2426
}
@@ -28,23 +30,23 @@ governing permissions and limitations under the License.
2830

2931
opacity: 1;
3032

31-
transition-delay: 0ms;
33+
transition-delay: var(--mod-overlay-animation-duration-opened, var(--spectrum-overlay-animation-duration-opened));
3234

3335
pointer-events: auto;
3436
}
3537

3638
%spectrum-overlay--bottom--open {
37-
transform: translateY(var(--spectrum-overlay-animation-distance));
39+
transform: translateY(var(--mod-overlay-animation-distance, var(--spectrum-overlay-animation-distance)));
3840
}
3941

4042
%spectrum-overlay--top--open {
41-
transform: translateY(calc(-1 * var(--spectrum-overlay-animation-distance)));
43+
transform: translateY(calc(-1 * var(--mod-overlay-animation-distance, var(--spectrum-overlay-animation-distance))));
4244
}
4345

4446
%spectrum-overlay--right--open {
45-
transform: translateX(var(--spectrum-overlay-animation-distance));
47+
transform: translateX(var(--mod-overlay-animation-distance, var(--spectrum-overlay-animation-distance)));
4648
}
4749

4850
%spectrum-overlay--left--open {
49-
transform: translateX(calc(-1 * var(--spectrum-overlay-animation-distance)));
51+
transform: translateX(calc(-1 * var(--mod-overlay-animation-distance, var(--spectrum-overlay-animation-distance))));
5052
}

components/overlay/metadata/mods.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
| Modifiable Custom Properties |
2+
| ----------------------------------------- |
3+
| `--mod-overlay-animation-distance` |
4+
| `--mod-overlay-animation-duration-opened` |

0 commit comments

Comments
 (0)