Skip to content

docs(S2): fix clipping in Picker custom value AvatarGroup example#9702

Merged
reidbarber merged 1 commit intomainfrom
docs-s2-picker-render-value-fix
Feb 26, 2026
Merged

docs(S2): fix clipping in Picker custom value AvatarGroup example#9702
reidbarber merged 1 commit intomainfrom
docs-s2-picker-render-value-fix

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Feb 26, 2026

Fixes the AvatarGroup getting clipped when rendered as a custom value in the Picker.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test the docs example and make sure the avatar group doesn't get clipped.

🧢 Your Project:

@github-actions github-actions bot added the S2 label Feb 26, 2026
@rspbot
Copy link

rspbot commented Feb 26, 2026

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with it, though a bit unfortunate that it doesn't left align the avatar with the placeholder
Do you have a screenshot of what it looks like without this change? I'm not sure where this ask came from

@reidbarber
Copy link
Member Author

Screenshot 2026-02-26 at 4 17 23 PM

@snowystinger Found in testing yesterday, the group gets barely clipped on the left.

@reidbarber reidbarber enabled auto-merge February 26, 2026 22:18
@reidbarber reidbarber added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit 04b7380 Feb 26, 2026
30 checks passed
@reidbarber reidbarber deleted the docs-s2-picker-render-value-fix branch February 26, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants