Skip to content

fix: ensure Dialog has the data-rac attribute #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

amitdahan
Copy link
Contributor

Related to #5748, like #6436 or #6452 but for Dialog.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Use Dialog, the rendered <section> doesn't have the data-rac attribute.

🧢 Your Project:

@yihuiliao yihuiliao changed the title Ensure Dialog has the data-rac attribute fix: ensure Dialog has the data-rac attribute Oct 15, 2024
@snowystinger snowystinger added this pull request to the merge queue Oct 15, 2024
@snowystinger
Copy link
Member

One thing to note incase this comes up.
This does now pass close to style and classname. However, TS should prevent people from accidentally accessing it

Merged via the queue into adobe:main with commit 9152d83 Oct 15, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants