Skip to content

Expose FieldErrorContext from RAC #5743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2024
Merged

Expose FieldErrorContext from RAC #5743

merged 1 commit into from
Jan 24, 2024

Conversation

vladislavsz
Copy link
Contributor

Closes #5742

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger merged commit 46ae331 into adobe:main Jan 24, 2024
@reidbarber reidbarber mentioned this pull request Apr 9, 2024
Closed
@SimenB
Copy link

SimenB commented Oct 24, 2024

The type here is odd - something (the build?) strips the | null 🤔

https://www.runpkg.com/?react-aria-components@1.4.1/src/FieldError.tsx#19
https://www.runpkg.com/?react-aria-components@1.4.1/dist/types.d.ts#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@snowystinger snowystinger snowystinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose FieldErrorContext from react-aria-components
4 participants
@vladislavsz @SimenB @devongovett @snowystinger