Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groupby #22

Merged
merged 4 commits into from
May 24, 2021
Merged

Fix groupby #22

merged 4 commits into from
May 24, 2021

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented May 24, 2021

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #22 (d271821) into master (8693896) will increase coverage by 2.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     94.02%   96.31%   +2.29%     
- Complexity      179      184       +5     
============================================
  Files            12       12              
  Lines           435      434       -1     
  Branches         76       76              
============================================
+ Hits            409      418       +9     
+ Misses           14        8       -6     
+ Partials         12        8       -4     
Impacted Files Coverage Δ Complexity Δ
...dobe/campaign/tests/logparser/ParseDefinition.java 97.14% <ø> (-0.08%) 26.00 <0.00> (ø)
...va/com/adobe/campaign/tests/logparser/LogData.java 98.64% <100.00%> (+13.71%) 29.00 <0.00> (+5.00)
...om/adobe/campaign/tests/logparser/StdLogEntry.java 96.00% <100.00%> (ø) 32.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8693896...d271821. Read the comment docs.

@baubakg baubakg merged commit 37039cc into master May 24, 2021
@baubakg baubakg deleted the fix-groupby branch May 24, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant