Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

127 implement a diff method #134

Merged
merged 5 commits into from
Jun 19, 2024
Merged

127 implement a diff method #134

merged 5 commits into from
Jun 19, 2024

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Jun 19, 2024

Description

We can now compare two LogData Objects

Related Issue

Fixes #127

How Has This Been Tested?

Field testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • [x ] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@baubakg baubakg linked an issue Jun 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.28%. Comparing base (dcba1f7) to head (a48141d).

Files Patch % Lines
...m/adobe/campaign/tests/logparser/core/LogData.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #134      +/-   ##
============================================
+ Coverage     95.07%   95.28%   +0.20%     
- Complexity      246      258      +12     
============================================
  Files            16       17       +1     
  Lines           609      636      +27     
  Branches         95      101       +6     
============================================
+ Hits            579      606      +27     
  Misses           19       19              
  Partials         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 19, 2024

@baubakg baubakg merged commit 1bd8f2c into main Jun 19, 2024
10 checks passed
@baubakg baubakg deleted the 127-implement-a-diff-method branch June 19, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a diff method
1 participant