Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next batch #125

Merged
merged 11 commits into from
Jun 15, 2024
Merged

Next batch #125

merged 11 commits into from
Jun 15, 2024

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Jun 14, 2024

Description

A series of corrections detected while using the tool.

Related Issue

Fixes #117
Fixes #123
Fixes #119

How Has This Been Tested?

unit tests

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] I have signed the Adobe Open Source CLA.
  • [x ] My code follows the code style of this project.
  • [ x] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.97%. Comparing base (1965149) to head (bae4d66).

Files Patch % Lines
...m/adobe/campaign/tests/logparser/core/LogData.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #125      +/-   ##
============================================
+ Coverage     94.41%   94.97%   +0.56%     
- Complexity      224      239      +15     
============================================
  Files            15       16       +1     
  Lines           555      597      +42     
  Branches         88       94       +6     
============================================
+ Hits            524      567      +43     
+ Misses           20       19       -1     
  Partials         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 15, 2024

@baubakg baubakg merged commit 9940f80 into main Jun 15, 2024
10 checks passed
@baubakg baubakg deleted the next-batch branch June 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Parsed size Remove deprecated methods Allow adding the path and the file in the data
1 participant