Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon should not be tracked #203

Open
kptdobe opened this issue Jun 12, 2024 · 1 comment
Open

Icon should not be tracked #203

kptdobe opened this issue Jun 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Jun 12, 2024

With #196, the picture > img selector has been replaced with img. For Helix sites, this means will start tracking icons as soon as a site uses enhancer@v2. This is where we should start having different code for Helix sites vs "CQ" site vs generic site for tracking.

cc @trieloff
@kptdobe kptdobe added the bug Something isn't working label Jun 12, 2024
@trieloff
Copy link
Contributor

@davidnuescheler always complained that the icon was not tracked. "The icon should be the most popular image on every site".
So I agree on the sentiment, but don't like the idea of different code bases yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trieloff @kptdobe