This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Add status bar error indicator clear shortcut #8997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds like a reasonable solution. |
|
@cheesypoof This works as expected, but it has a weird side-effect. The Statusbar Error indicator only is displayed if there are 1 or more errors in console, so by clearing the console, the button makes itself go away! This seems a little weird. What does everyone else think? |
|
@cheesypoof The core team is OK with this behavior, so merging. Thanks. |
redmunds
added a commit
that referenced
this pull request
Oct 13, 2014
Add status bar error indicator clear shortcut
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps it would be useful to add a shortcut to reset the status bar error indicator.
I don't feel strongly either way about the
Shiftclick modifier, so do let me know if another combination would be more appropriate. Also, perhaps just callingclearErrorCountinstead ofwindow.console.clear(which also obviously clears the console) would be sufficient. Thoughts?