Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@WebsiteDeveloper
Copy link
Contributor

Issue #5476
@larz0 to look at it.
cc @redmunds

Note: this doesn't fix the issue with the git extension dialog this is a separate issue as i mentioned in #5476
It does fix the install extension and the error dialog.

@ghost ghost assigned redmunds Oct 11, 2013
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value for width is auto, so I don't think this is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redmunds actually it is needed, because we need to override it.

@redmunds
Copy link
Contributor

Done with review. This seems to fix problem. One code cleanup comment.

@redmunds
Copy link
Contributor

Merging.

redmunds added a commit that referenced this pull request Oct 14, 2013
@redmunds redmunds merged commit 2f9ab13 into adobe:master Oct 14, 2013
@larz0
Copy link
Member

larz0 commented Oct 14, 2013

It's much better now thanks @WebsiteDeveloper

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants