Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Aug 10, 2013

Added new strings and two fixes to Finnish localization

@ghost
Copy link
Author

ghost commented Aug 12, 2013

Added Getting Started project

@ghost ghost assigned jasonsanjose Aug 16, 2013
@jasonsanjose
Copy link
Member

Posted to the google group to get a review https://groups.google.com/d/msg/brackets-dev/FJEJQyyMDqk/0mrtdLABieAJ.

@ghost
Copy link
Author

ghost commented Aug 26, 2013

It's previewed on Google Group.

@jasonsanjose
Copy link
Member

@valtlait you'll also need to add a file src/nls/fi/urls.js so that we can pick up the getting started content. See the french directory for an example. I've gone ahead and filled in the appropriate Finnish URLs below.

define({
    // Relative to the samples folder
    "GETTING_STARTED"           : "fi/Aloitus",
    "ADOBE_THIRD_PARTY"         : "http://www.adobe.com/go/thirdparty_fi/",
    "WEB_PLATFORM_DOCS_LICENSE" : "http://creativecommons.org/licenses/by/3.0/deed.fi"
});

@jasonsanjose
Copy link
Member

Looks good. There's one minor change to enable the getting started project. I'll do that separately. Thanks @valtlait.

jasonsanjose added a commit that referenced this pull request Sep 3, 2013
Update to Finnish localization
@jasonsanjose jasonsanjose merged commit f36b27f into adobe:master Sep 3, 2013
@lkcampbell
Copy link
Contributor

@jasonsanjose, seems like this translation of the sample project is missing the screenshot directory and graphic.

@jasonsanjose
Copy link
Member

Thanks. I'll file a bug.

@jasonsanjose
Copy link
Member

Filed #5077.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants