This repository was archived by the owner on Sep 6, 2021. It is now read-only.
fix failures in webplatform docs tests #4616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I totally missed this. Wasn't expecting the changes in #3429 to break other tests, besides the ones it modified. |
Member
Author
|
@TomMalbran no problem. You've got commit rights right? Care to merge? |
Member
|
Oops, sorry for missing this! I guess those tests didn't exist when I originally put up the pull request 4 months ago... At least the assertions are doing what they were designed to, and finding erroneous code :-P Looks right to me -- merging. |
peterflynn
added a commit
that referenced
this pull request
Jul 31, 2013
…tests fix failures in webplatform docs tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes breakage from #3429. @peterflynn can you review?