This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fixed issue #4489- "Save/Close All with multiple untitled documents gives ambiguous Save dialogs" #4514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Member
|
Cool -- this has several side effects that I like:
|
#4468 (comment)). Fixed as a side effect of PR #4514.
Member
|
@bchintx Code reviewed, look good to me. I wrote a quick unit test for the "side effect fix" issue mentioned above, and added it to your branch -- hope you don't mind. I verified that it fails without your patch and passes with it. Do you want to take a quick look at it before we merge this? |
Contributor
Author
|
@peterflynn Thanks for the comments, and thanks for adding the unit test. The commit you added looks great. Please feel free to merge this when you are ready. |
Member
|
Np! Merging... |
peterflynn
added a commit
that referenced
this pull request
Jul 22, 2013
Fixed issue #4489- "Save/Close All with multiple untitled documents gives ambiguous Save dialogs"
peterflynn
added a commit
that referenced
this pull request
Jul 23, 2013
…eanups * origin/master: (1140 commits) Documentation nits from code review Updated by ALF automation. Updated by ALF automation. Unit test for Save As bug related to untitled documents (see note at #4468 (comment)). Fixed as a side effect of PR #4514. - Add unit test that @bchintx wrote to cover #4484. - Remove redundant timeout args in unit tests (same val as default) - Fix JSLint whitespace errors I noticed in ProjectManager Using "workingSetSort" instead of "workingSetAdd" in certain cases of addToWorkingSet() was problematic, since FileViewController attaches specific meaning only to the latter. Cosmetic tweaks to modal header background color, tables, and typography. Attempt a cleaner fix for bug #4484 (Working set broken after Save As / save untitled outside project): * addToWorkingSet() ensures item is moved to requested index, even if it was already in the working set at some other index * Add a force flag, so we can guarantee a redraw after suppressing it during removal earlier * Call handleFileAddToWorkingSet() directly from _doSaveAs() to simplify plumbing (no advantage to going through FileViewController in this case) code review comments add registry URLs add unit tests for update button and registryUpdate event fix async close of dialog in afterEach update extension manager spinner and registry UI unit tests. update sanity check string. when prompting to save-as an untitled document, activate that document in the editor Updated by ALF automation. Disabling failing unit tests code review comments part 2 change layout for extension manager messages Updated by ALF automation. oops, of course can't use CollectionUtils... ... Conflicts: src/language/LanguageManager.js src/widgets/Dialogs.js test/spec/Editor-test.js test/spec/FileIndexManager-test.js test/spec/InstallExtensionDialog-test.js test/spec/SpecRunnerUtils.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #4489- "Save/Close All with multiple untitled documents gives ambiguous Save dialogs"
When prompting to save-as an untitled document, activate that document in the editor. This causes the untitled document to display in the editor and prepopulate the untitled document's name (eg. "Untitled-1") in the Save As dialog.
As a result, if the user does, for example, a Save All, then as each untitled document is prompting to save, Brackets will switch to and display that specific document.
Successfully completed all 'Unit", "Integration", and "Extensions" unit tests on both Mac and Win.