This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix #2645: [FRA, JPN]: The word "Loading..." is not localized. #3260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
looks good i couldn't really get the Loading... to show so no wonder i couldn't verify it worked, |
Contributor
|
Reviewing since I know an easy way to have the string show up. |
1 similar comment
Contributor
|
Reviewing since I know an easy way to have the string show up. |
Contributor
|
Great! It's working. So merging now. |
RaymondLim
added a commit
that referenced
this pull request
Mar 27, 2013
Fix #2645: [FRA, JPN]: The word "Loading..." is not localized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix by @WebsiteDeveloper didn't fixed this issue, since the strings preferences of the jstree need to be inside the core object. I tested it on other languages and the Loading string is localized.