Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@gruehle
Copy link
Member

@gruehle gruehle commented Dec 20, 2011

NOTE: This pull request is for discussion only, and is NOT intended to be pulled into master!

This is a first pass at applying the module proposal specified here:
https://zerowing.corp.adobe.com/display/brackets/Module+Proposal

There are a couple things to note:

  1. This is a snapshot of the code from 12/17
  2. A couple modules, NativeFileSystem and KeyBindingManager, don't strictly adhere to the spec. Both of them export full classes instead of just the public APIs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider using $.extend to make this a little more convenient:

$.extend(exports, {
FILE_OPEN: "file.open",
// etc.
});

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I like the convenience of $.extend(), but wonder if we want to depend on jQuery at this low of a level. This isn't an issue for Brackets right now, but could be an issue if we split any of our modules into separate repos/libraries.

This also raises another related question: do we want to allow modules to be extended by other modules? For example, should the Commands module know about all commands in the app, or should other modules like ProjectManager and EditorManager extend Commands to add in the commands used by those modules?

@gruehle
Copy link
Member Author

gruehle commented Jan 5, 2012

Closing this pull request. It is superseded by #45

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants