Fixes #1256 #1769
Fixes #1256 #1769
Conversation
ghost
assigned 
| @@ -45,6 +45,7 @@ define(function (require, exports, module) { | |||
| * - lostSync -- When the backing Document changes in such a way that the range can no longer | |||
| * accurately be maintained. Generally, occurs whenever an edit spans a range boundary. | |||
| * After this, startLine & endLine will be unusable (set to null). | |||
| * Also occurs when the document is deleted, thought startLine & endLine won't be modified | |||
There was a problem hiding this comment.
Yes! It's supposed to say "though". Good catch!
|
Done with initial review. |
|
Thank you for the review! Much appreciated! Personally I'm most skeptical about forwarding an event as the "cause" of another event. It feels fishy somehow. What are your thoughts on this? |
|
I can't think of other elegant alternatives that will let you distinguish between "deleted" and "out-of-sync". So I'm ok with forwarding the "cause". It is harder to understand it at first. I was almost to question you on how we get "deleted" as the cause, but later I figured out by doing global search. |
|
Thanks a lot for your review, much appreciated! I updated the comments as per your suggestions. Unless I overlooked anything, that's it from me for now. |
|
Looks good. Merging |
Fixes #1256: Deleting a file should remove entry from inline editor
This one could use a thorough review...