This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Improve console output of LiveDevelopment errors (#1200) #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: Some arguments of method 'Debugger.setBreakpointByUrl' can't be processed After: Some arguments of method 'Debugger.setBreakpointByUrl' can't be processed Parameter 'lineNumber' has wrong type. It must be 'Number'. Parameter 'url' has wrong type. It must be 'String'. [expandable error object]
|
See #1200 |
|
Thanks! Merging. |
gruehle
added a commit
that referenced
this pull request
Jul 11, 2012
Improve console output of LiveDevelopment errors (#1200)
|
Oops, it looks like this violates #1096 though. @DennisKehrig, are you planning any more work in this file? If so, we could wait and roll up the fix into a later pull request, instead of making a whole commit just for this one-line change... |
|
@peterflynn No, not right now... I just went ahead and added another pull request. I'm surprised this isn't mentioned in the Coding Conventions. Is it mentioned somewhere else? |
|
Thanks, guys! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Some arguments of method 'Debugger.setBreakpointByUrl' can't be processed
After:
Some arguments of method 'Debugger.setBreakpointByUrl' can't be processed
Parameter 'lineNumber' has wrong type. It must be 'Number'.
Parameter 'url' has wrong type. It must be 'String'.
[expandable error object]