OSX Yosemite: green “stoplight” doesn't show when you expand brackets to full mode.

[ghost]

As you know, Yosemite made the green button function as the full screen button. When you click on the full screen button, you can't see the green button therefore, you can't get out of fullscreen unless you close the application.

[ingorichter]

I think we need to remove the full screen button in order to make it consistent.

[JeffryBooher]

We still want the full screen button for Mavericks users so that means we need to detect the OS version at run-time and turn off the traffic lights and full screen button. I'd rather have nicer looking images for traffic lights but it is probably easier just to use the OS buttons on Yosemite since they have different behavior now.

We can circle back around on the anti-aliased buttons after Larz returns from Sabbatical.

[hibooboo2]

I think that you should make a manual one that works the same on all OSes so that you can have the same user experience. Make it behave as close to the same as on windows and linux as it is on mac.

[JeffryBooher]

Sending this to the board

[JeffryBooher]

[larz0]

@JeffryBooher @ingorichter I think it's fine. (cc @peterflynn @njx)

If we feel like we have time in this release (most probably not) then take a look at these assets: https://dribbble.com/shots/1698401-Yosemite-Traffic-light-Buttons-PSD?list=users&offset=0

[JeffryBooher]

@larz0 do you think it's important to know if it's a light or dark theme? he has different assets for each Yosemite theme.

[ingorichter]

the dark theme doesn't change the title bar of the window. Therefore I assume, it's not important.

[ghost]

true

[JeffryBooher]

@Viruska we have this fixed in Master if you can build it and test it for us that would be great. Thanks!

[ghost]

ok

[ghost]

Doesn't work. I still see the full-screen button.

[JeffryBooher]

@Viruska the fix was made in native code so you need to pull master on this repo https://github.com/adobe/brackets-shell

I wanted to confirm that you pulled master on that repo, built the app and are still seeing the old traffic lights and full screen button when you run that build.

[ghost]

Works now!

[rgolea]

Why don't you enable the esc button as exit fullscreen and leave it all like it is?

[vonStein]

The problem pops up again on 10.11 beta. Maybe checking for 10.10 and later would do the trick here.

[nethip]

@excomedia Thanks for reporting this! I am seeing this bug in 10.11. Let me check brackets-shell code to understand what might be causing this issue.

[nethip]

Found it! https://github.com/adobe/brackets-shell/blob/master/appshell/cefclient_mac.mm#L255 is the culprit. Will fix this!

[ingorichter]

There must be a better way to distinguish new from old OSX versions.

[nethip]

@ingorichter I am done with the fix. I will put up a PR for this.

[nethip]

@vonStein @ingorichter This is fixed now with this PR adobe/brackets-shell#526