Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Project tree file name filter preferences #8816

Open
pthiess opened this issue Aug 20, 2014 · 6 comments
Open

Project tree file name filter preferences #8816

pthiess opened this issue Aug 20, 2014 · 6 comments
Assignees

Comments

@pthiess
Copy link
Contributor

pthiess commented Aug 20, 2014

As a user I would like to define a customized list of filtered files in the Project file tree saved to my preferences.

This is somewhat complicated because the same ProjectManager._shouldShowName() filter is currently used as a low-level filter to make all of FileSystem ignore things (caching, watchers, Directory.getContents(), etc.). So it can't be changed easily at runtime, and has performance side-effects that may not be obvious to users.

Ideally we wouldn't need any special FileSystem-level filtering at all. It'd be great if we had a generic preference for excluding things from getAllFiles() clients without excluding them from the filesystem overall. That way we wouldn't traverse into those subtrees automatically, but they could still be exposed in the project tree for manual traversal (maybe with special styling indicating they’re "excluded" folders or such). With auto-recursive file watching on two of three platforms, we're tantalizingly close to that: if no one ever asks FileSystem to traverse into a subtree like .git or node_modules, it'll never be loaded, never take up cache space, and never be processed by a file-watcher listener. But Linux file watching throws a wrench in that pretty picture...

Use cases

@peterflynn peterflynn self-assigned this Aug 20, 2014
@pthiess
Copy link
Contributor Author

pthiess commented Sep 12, 2014

See PR #7166 for a contributed start of an implementation that does not take into account the filesystem piece of it.

@pthiess
Copy link
Contributor Author

pthiess commented Sep 12, 2014

@peterflynn
Copy link
Member

(more specifically, this came from Project tree file name filter preferences on Trello)

@ebordeau
Copy link

We have a lot of files that are used mainly for tooling and just clutter up the project tree. Ideally, I'd like to be able to set up a filter (e.g. don't show .* files) and be able to turn it on/off quickly (toggle button).

@redmunds
Copy link
Contributor

@ebordeau You can filter using the https://github.com/gruehle/exclude-folders extension. You'll have to do some additional work to make it toggle "quickly", but that can be done.

@ebordeau
Copy link

Thanks! That worked great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants