Remap ERR_UNSUPPORTED_ENCODING to NOT_READABLE_ERR

[mikechambers]

In NativeFileSystem.js the _nativeToFileError maps native file errors to HTML5 File Errors.

The specification states that for any errors that dont have a direct mapping, SECURITY_ERR should be used.

The following native errors are mapped to SECURITY_ERR:

• ERR_UNKNOWN
• ERR_INVALID_PARAMS
• ERR_UNSUPPORTED_ENCODING

This can make debugging errors difficult, as it requires developers to edit NativeFileSystem.js in order to see what the actual error is.

Looking at the w3c FileSystem specification that we appear to be following:

http://www.w3.org/TR/2011/WD-file-system-api-20110419/#error-code-descriptions

There is a NOT_READABLE_ERR, which is describe as:

user agent must use this code if a file or directory cannot be read, typically due due to permission problems that occur after a reference to a file has been acquired (e.g. concurrent lock with another application).

Which suggest that it should only be used for "permission problems".

However, looking at the most recent specification:

http://www.w3.org/TR/file-system-api/#definitions

The NOT_READABLE_ERR is describe as being for:

A required file or directory could be read.

So, I think we should map the native ERR_UNSUPPORTED_ENCODING error to the HTML / JavaScript NOT_READABLE_ERR, as it seems to map closer than SECURITY_ERR does.

[pthiess]

reviewed

[njx]

Marking as starter bug.

[dannyp32]

I'm an absolute beginner and I'd like to help out. It seems like all I need to do is change all FileError.SECURITY_ERR to FileError.NOT_READABLE_ERR in NativeFileSystem.js
Is that correct?

Also, how can I assign this to myself?

[gruehle]

@dannyp32 - yep, that's it!

Please make sure you sign the CLA before submitting the pull request:
http://dev.brackets.io/brackets-contributor-license-agreement.html

We typically only assign bugs to internal team members. For external contributors, it's best to add a comment to the bug that says you are working on it.

Thanks!

[dannyp32]

Changing some of the exceptions makes the comments outdated...what should I do about this? ...I don't know what you guys would like to add as comments

Also, I don't know if it should be changed in this part of the code, but let me know if I should remove it and move all of the others up one position (I didn't write all of them, there's 10 in total).

Object.defineProperties(
NativeFileSystem.FileException,
{
NOT_FOUND_ERR: { value: 1, writable: false },
SECURITY_ERR: { value: 2, writable: false },
ABORT_ERR: { value: 3, writable: false },
NOT_READABLE_ERR: { value: 4, writable: false },
ENCODING_ERR: { value: 5, writable: false },
NO_MODIFICATION_ALLOWED_ERR: { value: 6, writable: false },
}
}

[dannyp32]

actually there's 9 ....the value skips from 8 to 10 on the last two

[jasonsanjose]

Fixed in #2639