Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Themes] Language button in status bar has a white border on top edge. #8389

Closed
RaymondLim opened this issue Jul 14, 2014 · 6 comments · Fixed by #8521
Closed

[Themes] Language button in status bar has a white border on top edge. #8389

RaymondLim opened this issue Jul 14, 2014 · 6 comments · Fixed by #8521
Assignees
Milestone

Comments

@RaymondLim
Copy link
Contributor

  1. Switch theme to Thor Dark. (View > Themes and select Thor Dark from the list in the dialog)
  2. Look at the status bar.

Result: Language bar seems to have a white box shadow on top edge.

@redmunds
Copy link
Contributor

Screenshot:
themes-statusbar-type

@RaymondLim RaymondLim added this to the Release 0.42 milestone Jul 14, 2014
@RaymondLim RaymondLim self-assigned this Jul 14, 2014
@redmunds redmunds changed the title Language button in status bar has a white border on top edge. [Themes] Language button in status bar has a white border on top edge. Jul 21, 2014
@dangoor
Copy link
Contributor

dangoor commented Jul 22, 2014

This is actually fixed now because the status bar is light for this release (see #8412).

OK to close this, @RaymondLim?

@TomMalbran
Copy link
Contributor

@dangoor This will soon be an issue, and even if we can't see it in the light theme, we should remove the box-shadow, the text-shadow and the border-radius. It is also a really easy to fix. I can make a PR for it.

@peterflynn
Copy link
Member

@TomMalbran There's Raymond's fix #8397 posted already, and I think @larz0 has a fix for this in his PR #8362 too...

@RaymondLim
Copy link
Contributor Author

I can close mine since @TomMalbran solution is more general in CSS that can apply to any button in status bar.

@TomMalbran
Copy link
Contributor

Oh, I didn't saw Raymond's fix. But maybe an option in the Dropdown button to remove the btn class might work good too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.