Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Feature request: invoking Google search via Quick Open #7194

Closed
larz0 opened this issue Mar 13, 2014 · 7 comments
Closed

Feature request: invoking Google search via Quick Open #7194

larz0 opened this issue Mar 13, 2014 · 7 comments

Comments

@larz0
Copy link
Member

larz0 commented Mar 13, 2014

Something like this:

brackets_googlesearch_001

It should show the search results in Chrome (same browser as live preview).

@peterflynn
Copy link
Member

@larz0 It should be easy to do in an extension if you're willing to have a prefix on the search string (like other Quick Open plugins). Do you actually think this should be default behavior in core? Also, what about other online searches -- GitHub code search, stackoverflow, MDN, etc. might actually feel more relevant to developers. I don't know how much of an assumption we'd want to bake in there...

@larz0
Copy link
Member Author

larz0 commented Mar 13, 2014

Ahh that led me to this https://github.com/peterflynn/brackets-editor-nav. Maybe we could just extend your extension and see what happens :)

@peterflynn
Copy link
Member

@larz0 That extension doesn't do any online searches or anything, so it's probably not a good fit there... but it's certainly a good example of how an extension can easily plug into the Quick Open functionality.

@TomMalbran
Copy link
Contributor

Another option would be to just use a bottom panel that loads any of those pages inside Brackets.

@larz0
Copy link
Member Author

larz0 commented Mar 13, 2014

I'm able to load Bing in Brackets but not Google because of Google's same origin policy.

http://github.com/larz0/bottom-browser

@peterflynn
Copy link
Member

I don't think it's same-origin, it's probably a no-frame header. There are security concerns about browsing to arbitrary untrusted web content inside brackets-shell though, so I'd be hesitant about doing this in core. (It also has downsides like no bookmarking, no back/fwd buttons or URL bar for free, no shared cookies with your main browser session, etc.)

@dangoor
Copy link
Contributor

dangoor commented Mar 19, 2014

Closing as extension idea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants