Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Code Cleanup: Live Dev _loadedAgentNames is not accurate. #3390

@redmunds

Description

@redmunds

This was split off of pull #3203

In LiveDevelopment.js loadAgents() function, agent names are synchronously added to the _loadedAgentNames array after calling agents[name].load(). Seems like they should only be in the list if the call to load() is resolved.

This does not seem to cause any known problem. It just seems to imply that it contains a list of successfully loaded agents and someone may try to use that for something in the future. Possible solutions:

  1. If it simply contains the same list as _enabledAgentNames, then the _loadedAgentNames array is not needed
  2. If the _loadedAgentNames array is needed, then it should be accurate.
  3. The name should be changed to describe what's actually in the array.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions