Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

shortcut to hide panels, e.g. search #11764

Open
tobibeer opened this issue Sep 30, 2015 · 5 comments
Open

shortcut to hide panels, e.g. search #11764

tobibeer opened this issue Sep 30, 2015 · 5 comments

Comments

@tobibeer
Copy link

I often find myself wanting to close the "search in folder" panel after finding what I was looking for, that is without having to locate and click a tiny close button in the search panel via mouse.

A shortcut would be real nice or, better yet, a global module that allows to associate shortcuts with available ui functions.

@petetnt
Copy link
Collaborator

petetnt commented Oct 1, 2015

You can associate shortcuts available by modifying the keymap.json file.

That said, SearchResultsView.js doesn't register the close command via CommandManager so it can't be added as an shortcut that way (yet). Pinging @abose

@abose
Copy link
Contributor

abose commented Oct 1, 2015

#11732 Targeted for 1.6 adds new panel management API's that can be used by extensions to control panels in the UI. Extensions could use those API's to implement the requested feature [register the shortcut and hide panels by name]. More panel management stories are being picked up for 1.6. I do not know if we should add a shortcut for this alone in core.
Should we add a shortcut to hide all panels instead?

@petetnt
Copy link
Collaborator

petetnt commented Oct 1, 2015

I think Hide all panels shortcut makes sense, at least until something like #11586 lands in.

@tobibeer
Copy link
Author

tobibeer commented Oct 1, 2015

I do not know if we should add a shortcut for this alone in core.
Should we add a shortcut to hide all panels instead?

  • yes, the basic request would then be for a shortcut to close all panels
  • a second shortcut might be to just close the active panel (and return to the last active one)

With tabbed panels, it would be nice to be able to define shortcuts to toggle panels individually.

@tobibeer tobibeer changed the title shortcut to hide search panel shortcut to hide panels, e.g. search Oct 1, 2015
@abose abose added this to the Release 1.6 milestone Oct 6, 2015
@abose
Copy link
Contributor

abose commented Oct 7, 2015

Updated #11732 with shortcut to toggle panels.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants
@tobibeer @abose @petetnt and others