Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

feature: close split view automatically #11746

Closed
zaggino opened this issue Sep 26, 2015 · 3 comments
Closed

feature: close split view automatically #11746

zaggino opened this issue Sep 26, 2015 · 3 comments

Comments

@zaggino
Copy link
Contributor

zaggino commented Sep 26, 2015

steps:

  1. open preferences file
  2. split view opens
  3. click to close the brackets.json in the right pane, nothing else is remaining in the right pane

i believe, that the split view should now close automatically, given it was also automatically opened

@petetnt
Copy link
Collaborator

petetnt commented Sep 26, 2015

Makes sense in the preferences scenario, but in general I think that the preferences split view should be more isolated anyway. Auto-closing the panel when it's possible to modify the views while the preferences are open is a bit tricky too. Consider something like this:

  1. Open preferences file
  2. Split view opens
  3. Drag another file to right panel
  4. Close brackets.json -> Right view should stay open right?

But what if

  1. Drag the file back to left panel
  2. Close brackets.json - nothing stays in the right panel but it shouldn't auto close as it has been "dirty" - right?

@zaggino
Copy link
Contributor Author

zaggino commented Sep 26, 2015

Well, I'd implement it in a way that if split-view was automatically opened it also should automatically close. If it was opened manually, it should never auto-close. I don't really like split view and how it's forcing itself anytime I want to change something in preferences.

@petetnt
Copy link
Collaborator

petetnt commented Feb 16, 2017

This was added in #11749 right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants
@zaggino @abose @petetnt @ficristo and others