code review comments

Author: jasonsanjose

src/LiveDevelopment/Documents/CSSDocument.js

@@ -73,7 +73,7 @@ define(function CSSDocumentModule(require, exports, module) {
         $(this.doc).on("deleted.CSSDocument", this.onDeleted);
 
         this.onActiveEditorChange = this.onActiveEditorChange.bind(this);
-        $(EditorManager).on("activeEditorChange.CSSDocument", this.onActiveEditorChange);
+        $(EditorManager).on("activeEditorChange", this.onActiveEditorChange);
 
         if (editor) {
             // Attach now
@@ -113,9 +113,8 @@ define(function CSSDocumentModule(require, exports, module) {
 
     /** Close the document */
     CSSDocument.prototype.close = function close() {
-        $(this.doc).off("change.CSSDocument");
-        $(this.doc).off("deleted.CSSDocument");
-        $(EditorManager).off("activeEditorChange.CSSDocument");
+        $(this.doc).off(".CSSDocument");
+        $(EditorManager).off("activeEditorChange", this.onActiveEditorChange);
         this.doc.releaseRef();
         this.detachFromEditor();
     };
@@ -137,7 +136,7 @@ define(function CSSDocumentModule(require, exports, module) {
         this.editor = editor;
 
         if (this.editor) {
-            $(HighlightAgent).on("highlight.CSSDocument", this.onHighlight);
+            $(HighlightAgent).on("highlight", this.onHighlight);
             $(this.editor).on("cursorActivity.CSSDocument", this.onCursorActivity);
             this.updateHighlight();
         }
@@ -146,8 +145,8 @@ define(function CSSDocumentModule(require, exports, module) {
     CSSDocument.prototype.detachFromEditor = function () {
         if (this.editor) {
             HighlightAgent.hide();
-            $(HighlightAgent).off("highlight.CSSDocument");
-            $(this.editor).off("cursorActivity.CSSDocument");
+            $(HighlightAgent).off("highlight", this.onHighlight);
+            $(this.editor).off(".CSSDocument");
             this.onHighlight();
             this.editor = null;
         }

src/LiveDevelopment/LiveDevelopment.js

@@ -213,7 +213,10 @@ define(function LiveDevelopment(require, exports, module) {
 
         if (index !== -1) {
             _relatedDocuments.splice(index, 1);
-            _server.remove(liveDoc);
+            
+            if (_server) {
+                _server.remove(liveDoc);
+            }
         }
     }
 
@@ -266,7 +269,7 @@ define(function LiveDevelopment(require, exports, module) {
         function createLiveStylesheet(url) {
             var stylesheetDeferred  = $.Deferred(),
                 promise             = stylesheetDeferred.promise(),
-                path                = _server.urlToPath(url);
+                path                = _server && _server.urlToPath(url);
 
             // path may be null if loading an external stylesheet
             if (path) {
@@ -998,7 +1001,7 @@ define(function LiveDevelopment(require, exports, module) {
         // close the current session and begin a new session if the current
         // document changes to an HTML document that was not loaded yet
         var wasRequested = agents.network && agents.network.wasURLRequested(doc.url),
-            isViewable = exports.config.experimental || _server.canServe(doc.file.fullPath);
+            isViewable = exports.config.experimental || (_server && _server.canServe(doc.file.fullPath));
 
         if (!wasRequested && isViewable) {
             // TODO (jasonsanjose): optimize this by reusing the same connection