Fix bug with Select Line around end of inline editor range, and add unit

tests for it.

Author: peterflynn

src/editor/EditorCommandHandlers.js

@@ -301,6 +301,14 @@ define(function (require, exports, module) {
             var sel  = editor.getSelection();
             var from = {line: sel.start.line, ch: 0};
             var to   = {line: sel.end.line + 1, ch: 0};
+            
+            if (to.line === editor.getLastVisibleLine() + 1) {
+                // Last line: select to end of line instead of start of (hidden/nonexistent) following line,
+                // which due to how CM clips coords would only work some of the time
+                to.line -= 1;
+                to.ch = editor.document.getLine(to.line).length;
+            }
+            
             editor.setSelection(from, to);
         }
     }

test/spec/EditorCommandHandlers-test.js

@@ -1006,13 +1006,29 @@ define(function (require, exports, module) {
 
         describe("Select Line - editor with visible range", function () {
 
-            it("shouldn't select past end of visible range", function () {
+            it("shouldn't select past end of visible range, IP in middle of last visible line", function () {
                 makeEditorWithRange({startLine: 1, endLine: 5});
                 myEditor.setSelection({line: 5, ch: 4}, {line: 5, ch: 4});
                 CommandManager.execute(Commands.EDIT_SELECT_LINE, myEditor);
 
                 expectSelection({start: {line: 5, ch: 0}, end: {line: 5, ch: 5}});
             });
+            
+            it("shouldn't select past end of visible range, IP at start of last visible line", function () {
+                makeEditorWithRange({startLine: 1, endLine: 5});
+                myEditor.setSelection({line: 5, ch: 0}, {line: 5, ch: 0});
+                CommandManager.execute(Commands.EDIT_SELECT_LINE, myEditor);
+                
+                expectSelection({start: {line: 5, ch: 0}, end: {line: 5, ch: 5}});
+            });
+            
+            it("should extend selection to include last line of visible range", function () {
+                makeEditorWithRange({startLine: 1, endLine: 5});
+                myEditor.setSelection({line: 4, ch: 4}, {line: 4, ch: 4});
+                CommandManager.execute(Commands.EDIT_SELECT_LINE, myEditor);
+                
+                expectSelection({start: {line: 4, ch: 0}, end: {line: 5, ch: 0}});
+            });
         });
 
     });