Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 8b4c7b2

Browse files
committed
Don't write pref on initial load, per review
1 parent 83eb276 commit 8b4c7b2

File tree

1 file changed

+6
-4
lines changed
  • src/extensions/default/QuickView

1 file changed

+6
-4
lines changed

src/extensions/default/QuickView/main.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -739,11 +739,13 @@ define(function (require, exports, module) {
739739
CommandManager.get(CMD_ENABLE_QUICK_VIEW).setChecked(enabled);
740740
}
741741

742-
function setExtensionlessImagePreview(_extensionlessImagePreview) {
742+
function setExtensionlessImagePreview(_extensionlessImagePreview, doNotSave) {
743743
if(extensionlessImagePreview !== _extensionlessImagePreview) {
744744
extensionlessImagePreview = _extensionlessImagePreview;
745-
prefs.set("extensionlessImagePreview", enabled);
746-
prefs.save();
745+
if (!doNotSave) {
746+
prefs.set("extensionlessImagePreview", enabled);
747+
prefs.save();
748+
}
747749
}
748750
}
749751

@@ -814,7 +816,7 @@ define(function (require, exports, module) {
814816

815817
// Setup initial UI state
816818
setEnabled(prefs.get("enabled"), true);
817-
setExtensionlessImagePreview(prefs.get("extensionlessImagePreview"));
819+
setExtensionlessImagePreview(prefs.get("extensionlessImagePreview"), true);
818820

819821
prefs.on("change", "enabled", function () {
820822
setEnabled(prefs.get("enabled"), true);

0 commit comments

Comments
 (0)