Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 6582ee6

Browse files
committed
Merge pull request #2562 from iwehrman/iwehrman/implicit-hints-on-enter-and-tab
Implicit hint requests only on enter and tab keydown events
2 parents 912e540 + 65f4ead commit 6582ee6

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/editor/CodeHintManager.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,10 @@ define(function (require, exports, module) {
450450
} else if (_inSession(editor) && hintList.isOpen()) {
451451
// Pass event to the hint list, if it's open
452452
hintList.handleKeyEvent(event);
453-
} else {
453+
} else if (!(event.ctrlKey || event.altKey || event.metaKey) &&
454+
(event.keyCode === KeyEvent.DOM_VK_ENTER ||
455+
event.keyCode === KeyEvent.DOM_VK_RETURN ||
456+
event.keyCode === KeyEvent.DOM_VK_TAB)) {
454457
lastChar = String.fromCharCode(event.keyCode);
455458
}
456459
} else if (event.type === "keypress") {

0 commit comments

Comments
 (0)