Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 5ffdc97

Browse files
Delete unregister function, add unit test for getProvidersForPath.
1 parent 36e9908 commit 5ffdc97

File tree

2 files changed

+13
-25
lines changed

2 files changed

+13
-25
lines changed

src/language/CodeInspection.js

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -468,30 +468,6 @@ define(function (require, exports, module) {
468468
run(); // in case a file of this type is open currently
469469
}
470470

471-
/**
472-
* Deregisters a provider, given a languageId and the provider.
473-
* Allows code to remove providers which provide the same functionality
474-
* as the code provides
475-
*
476-
* @param {string} languageId
477-
* @param {{name:string, scanFileAsync:?function(string, string):!{$.Promise},
478-
* scanFile:?function(string, string):?{errors:!Array, aborted:boolean}}} provider
479-
*
480-
* @return {boolean} Returns true if at least one provider was removed.
481-
*/
482-
function unregister(languageId, providerName) {
483-
var isRemoved = false;
484-
if (_providers[languageId]) {
485-
_.remove(_providers[languageId], function (registeredProvider) {
486-
if (registeredProvider.name === providerName) {
487-
isRemoved = true;
488-
return true;
489-
}
490-
});
491-
}
492-
return isRemoved;
493-
}
494-
495471
/**
496472
* Update DocumentManager listeners.
497473
*/
@@ -668,7 +644,6 @@ define(function (require, exports, module) {
668644

669645
// Public API
670646
exports.register = register;
671-
exports.unregister = unregister;
672647
exports.Type = Type;
673648
exports.toggleEnabled = toggleEnabled;
674649
exports.inspectFile = inspectFile;

test/spec/CodeInspection-test.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,19 @@ define(function (require, exports, module) {
167167
});
168168
});
169169

170+
it("should get the correct linter given a file path", function () {
171+
var codeInspector1 = createCodeInspector("text linter 1", successfulLintResult());
172+
var codeInspector2 = createCodeInspector("text linter 2", successfulLintResult());
173+
174+
CodeInspection.register("javascript", codeInspector1);
175+
CodeInspection.register("javascript", codeInspector2);
176+
177+
var providers = CodeInspection.getProvidersForPath("test.js");
178+
expect(providers.length).toBe(2);
179+
expect(providers[0]).toBe(codeInspector1);
180+
expect(providers[1]).toBe(codeInspector2);
181+
});
182+
170183
it("should run two linters", function () {
171184
var codeInspector1 = createCodeInspector("text linter 1", successfulLintResult());
172185
var codeInspector2 = createCodeInspector("text linter 2", successfulLintResult());

0 commit comments

Comments
 (0)