Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@ingorichter
Copy link
Contributor

@peterflynn @redmunds @dangoor @RaymondLim @njx @JeffryBooher @pthiess Is there more that needs to be mentioned for this release? Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This card was just to add menu items for the previous card to match what Find in Files already had, so I don't think it's worth mentioning as a separate item.

@redmunds
Copy link
Contributor

I think we should add an item for JavaScript Code Hinting Crash Prevention as implemented in this PR. It got split off of the JS Code Hints automatic crash preventer Trello Card which is why you don't see it in the Ship It! Column.

{
    "name": "JavaScript Code Hinting Crash Prevention",
    "description": "Brackets now uses the timeout feature in Tern to detect and terminate hung web workers, which could cause Brackets to crash."
}

@redmunds
Copy link
Contributor

It might be worth mentioning "installing extensions with post-install dialogs causes brackets to hang" work.

@marcelgerber
Copy link
Contributor

@redmunds I don't think so. It was a bug introduced in this Release and fixed in this Release. The bug never got its way into a Release build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want "Release 41"? (see #146 (diff))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is a good point. Who is using the string? Is there something on brackets.io/index.html?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing hardcoded (any more). Just make sure the GitHub download URL is like https://github.com/adobe/brackets/releases/download/release-0.41/Brackets.Release.0.41.ext.
If that doesn't fit, we can make the website code fit, too.

@dangoor
Copy link

dangoor commented Jun 24, 2014

@redmunds Good point about the JS code hints crash prevention. Definitely agree we should add it. Perhaps the description could be something like Brackets automatically stops processing problematic JavaScript files that previously could cause a crash? I'm just thinking of text that's easier to grok as an end user.

@dangoor
Copy link

dangoor commented Jun 24, 2014

Do we want to add a note about the ability to rename on click and hold?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. We need not mention this in the update notification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- didn't know that. I agree it shouldn't be included.

@redmunds
Copy link
Contributor

@ingo @SAplayer @dangoor I made changes to address the last couple issues. I also slightly re-worded the first item.

Let me know ASAP if you have any more suggestions -- we need to complete this by end-of-day today.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't want to keep this one, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought it went away. what happened?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Removed.

@dangoor
Copy link

dangoor commented Jun 24, 2014

Anyone else think that "rename on click and hold" in the file tree should be mentioned? It's not clear to me that it's discoverable.

@redmunds
Copy link
Contributor

@dangoor It's actually click a second time on already selected item, but I don't think it's worth mentioning. Anyone else think we should add it?

@redmunds
Copy link
Contributor

Merging so I can notify Loc. We can make more tweaks if necessary.

redmunds added a commit that referenced this pull request Jun 24, 2014
first draft for release 0.41 update notifications
@redmunds redmunds merged commit bdf1b3b into master Jun 24, 2014
@redmunds redmunds deleted the ingo/release-0.41 branch June 24, 2014 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants