Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log login exception with context "aio-cli-plugin-cloudmanager" #41

Open
kwin opened this issue Jul 24, 2023 · 2 comments
Open

Log login exception with context "aio-cli-plugin-cloudmanager" #41

kwin opened this issue Jul 24, 2023 · 2 comments

Comments

@kwin
Copy link
Contributor

kwin commented Jul 24, 2023

Currently the code in getTokenAndKey silently catches all exceptions and falls back to the context cli.
That makes it close to impossible to debug issues with the context aio-cli-plugin-cloudmanager. Therefore I would suggest the following:

Only fall back to cli if there is no config at all for aio-cli-plugin-cloudmanager and pass the original exception to the caller otherwise.

@RemoLiechti
Copy link
Collaborator

We will revisite IMS usage in the plugin pretty soon and take this into account in the same go, thank you.

@RemoLiechti
Copy link
Collaborator

tagged: SKYOPS-76944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants