[AMSDK-11201] - Differentiate XDM vs standard shared state via eventName #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalehaha
reviewed
Mar 30, 2021
| @@ -180,7 +180,7 @@ final class EventHub { | |||
| } | |||
|
|
|||
| sharedState.set(version: version, data: data) | |||
| self.dispatch(event: self.createSharedStateEvent(extensionName: extensionName)) | |||
| self.dispatch(event: self.createSharedStateEvent(extensionName: extensionName, sharedStatetype: sharedStateType)) | |||
Codecov Report
@@ Coverage Diff @@
## staging #593 +/- ##
========================================
Coverage 85.27% 85.27%
========================================
Files 102 102
Lines 4541 4542 +1
========================================
+ Hits 3872 3873 +1
Misses 669 669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different eventName to differentiate between XDM vs standard shared state change event
Standard state change event name = "Shared state change"
XDM state change event name = "Shared state change (XDM)"
Unit tests are updated