Version nil event shared state at 0 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing to take a look at a few other implications |
nporter-adbe
commented
Sep 15, 2020
| @@ -243,7 +243,16 @@ final class EventHub { | |||
| // TODO: Determine which version of Core to use in the top level version field | |||
| let data: [String: Any] = [EventHubConstants.EventDataKeys.VERSION: ConfigurationConstants.EXTENSION_VERSION, | |||
| EventHubConstants.EventDataKeys.EXTENSIONS: extensionsInfo] | |||
| createSharedState(extensionName: EventHubConstants.NAME, data: data, event: nil) | |||
|
|
|||
| guard let sharedState = registeredExtensions.first(where: { $1.sharedStateName == EventHubConstants.NAME })?.value.sharedState else { | |||
There was a problem hiding this comment.
This is a bit of a special case where the is no event to version off of but we still need to set it to the latest shared state for event hub.
shalehaha
approved these changes
Sep 16, 2020
pfransenadb
approved these changes
Sep 17, 2020
|
Even though we have some other shared state discussions going on, I'm going to merge this as:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a nil event would version shared state at the latest, instead, now we version shared state at 0 when the event is nil. This is done to resolve the issue faced in #296