Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration should dispatch regular events for all update APIs and response events for getters #557

Closed
emdobrin opened this issue Mar 2, 2021 · 2 comments · Fixed by #552
Assignees
Labels
bug Something isn't working. Used by issue templates coresquad

Comments

@emdobrin
Copy link
Contributor

emdobrin commented Mar 2, 2021

Expected Behaviour

Configuration should dispatch regular events for all update APIs and paired response events for getters.

Actual Behaviour

Configuration returns only paired response events. The result of this is that the regular listeners don't receive config updates, as they are all paired.
Note: This does not impact the extensions using wildcard listeners, as the paired response events will be visible to them.

Reproduce Scenario (including but not limited to)

Found while fixing #551
See conversation #552 (comment)

Steps to Reproduce

Platform and Version

3.0.0

Sample Code that illustrates the problem

Logs taken while reproducing problem

@emdobrin emdobrin added bug Something isn't working. Used by issue templates coresquad labels Mar 2, 2021
@nporter-adbe nporter-adbe self-assigned this Mar 2, 2021
@nporter-adbe nporter-adbe linked a pull request Mar 2, 2021 that will close this issue
@emdobrin
Copy link
Contributor Author

emdobrin commented Mar 2, 2021

@nporter-adbe I fixed this in my PR because the integration tests were failing for Signal and Lifecycle

@nporter-adbe
Copy link
Contributor

@emdobrin Ok, you can either close my PR or merge it and bring those changes into your branch. I was under the impression that as it was a separate issue it would come in a separate PR.

In this case, I'll unassign myself from the issue and assign you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Used by issue templates coresquad
Projects
None yet
2 participants