SITES-28169: Resolves the unit test issue with higher graphql client … #1024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
============================================
- Coverage 89.14% 88.04% -1.10%
Complexity 2247 2247
============================================
Files 355 329 -26
Lines 10097 8617 -1480
Branches 1461 1461
============================================
- Hits 9001 7587 -1414
+ Misses 790 724 -66
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alwinjoseph02
force-pushed
the
bugfix/SITES-28169-unit-test-graphql-client
branch
from
2a9f079 to
0c57924
Compare
|
@alwinjoseph02 , good job on fixing this! It just occurred to me on seeing the many places we needed changes for this simple fix on the graphql. client config, I wonder if we could reduce a bit the boilerplate on these tests? Utility methods or a base test class may be places to pull out code duplicates and other boilerplate. WDYT? We could have quick call on this. |
|
@LSantha That would be a good idea . Lets discuss on it whenever you are free. |
| * @param context The AEM context. | ||
| * @param graphqlClient The GraphqlClient service. | ||
| */ | ||
| public static void activateGraphqlClient(AemContext context, GraphqlClient graphqlClient, Map<String, Object> additionalConfig) { |
There was a problem hiding this comment.
registerGraphqlClient() would be a better name here.
…version
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: