Skip to content

SITES-19938 - Build failure fix when project parent folder contains s… #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

bhavya-karodi
Copy link
Collaborator

…pace

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@bhavya-karodi bhavya-karodi requested a review from LSantha June 28, 2024 13:12
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (2cdea98) to head (0c77f19).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1012   +/-   ##
=========================================
  Coverage     89.11%   89.11%           
  Complexity     2226     2226           
=========================================
  Files           355      355           
  Lines         10042    10042           
  Branches       1447     1447           
=========================================
  Hits           8949     8949           
  Misses          790      790           
  Partials        303      303           
Flag Coverage Δ
integration 51.82% <ø> (ø)
jest 86.68% <ø> (ø)
karma 95.54% <ø> (ø)
unittests 87.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LSantha
Copy link
Collaborator

LSantha commented Jun 28, 2024

@bhavya-karodi , I've pushed a small fix in the PR. Could you please run the test on a WIndows machine to see if it works?

@LSantha LSantha merged commit 2ea43ba into master Jul 2, 2024
19 checks passed
@LSantha LSantha deleted the issue/SITES-19938 branch July 2, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants