Skip to content

Commit cb0a68c

Browse files
author
Ravisanker E
committed
bug fixes in review component
1 parent 9be378d commit cb0a68c

File tree

2 files changed

+38
-11
lines changed

2 files changed

+38
-11
lines changed
Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,27 @@
1-
/* Review component styles */
2-
/* Add your custom styles here */
1+
:root {
2+
--color-action-border-primary-disabled: #a3baf9;
3+
}
4+
5+
main .form form .review-container {
6+
display: block;
7+
}
8+
9+
main .form .review-container label {
10+
margin:0;
11+
position: relative;
12+
}
13+
14+
main .form .review-container .field-wrapper:not(.panel-wrapper, .plain-text-wrapper, .file-wrapper) {
15+
border-left: 3px solid var(--color-action-border-primary-disabled);
16+
padding-left: 1rem;
17+
padding-right: 1rem;
18+
19+
}
20+
21+
main .form .review-panel-wrapper {
22+
display: grid;
23+
}
24+
25+
main .form .review-panel-wrapper .checkbox-wrapper {
26+
margin: 5px;
27+
}

blocks/form/components/review/review.js

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,15 @@ function replaceInputs(element, model) {
2525
item.items?.forEach(processItem);
2626
return;
2727
}
28+
const { fieldType, id } = item;
2829

29-
if (!item.value || !item.id) return;
30-
31-
// Remove empty fields
32-
element.querySelector(`[data-id="${item.id}"]`)?.remove();
30+
if (fieldType === 'button') {
31+
element.querySelector(`[data-id="${id}"]`)?.remove();
32+
return;
33+
}
3334

35+
if (!item.value || !item.id) return;
3436
const divElement = createReviewFieldElement(item);
35-
const { fieldType, id } = item;
3637

3738
if (fieldType === 'radio-group' || fieldType === 'checkbox-group') {
3839
const group = element.querySelector(`fieldset[data-id="${id}"]`);
@@ -58,12 +59,13 @@ function replaceInputs(element, model) {
5859
}
5960

6061
function render(element, fd, model) {
61-
if (element.hasAttribute('data-rendered')) return;
62+
element.innerHTML = '';
63+
if (!model) return;
6264

6365
const { form } = model;
6466
const { properties } = fd;
6567

66-
if (!properties?.panelNames || !form) return;
68+
if (!properties?.panelNames) return;
6769

6870
const panelModels = [];
6971
form.visit((field) => {
@@ -73,7 +75,7 @@ function render(element, fd, model) {
7375
});
7476

7577
panelModels.forEach(async (field) => {
76-
if (!field.isContainer && !field.value) return;
78+
if (!field.isContainer) return;
7779

7880
const panelWrapper = document.createElement('div');
7981
panelWrapper.className = `review-panel-wrapper ${field.name}`;
@@ -83,7 +85,7 @@ function render(element, fd, model) {
8385

8486
if (!decoratedPanel) return;
8587

86-
element.setAttribute('data-rendered', 'true');
88+
element.appendChild(panelWrapper);
8789
});
8890
}
8991

0 commit comments

Comments
 (0)