Skip to content

poetry: unlock cryptography versions to prevent conflicts with other packages #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

markjm
Copy link

@markjm markjm commented Nov 6, 2024

Summary

Currently, cryptography is pinned to cryptography = "^38.0.4". In poetry, this expands to >=38.04,<39.

This worked well for old cryptography package versions since they always looked like 3.X.Y, but starting in 35.* versioning changed.

See https://cryptography.io/en/latest/api-stability/#versioning for specifics - essentially a major version change does not indicate breaking changes necessarily.

In short, code that runs without warnings will always continue to work for a period of two major releases.

From time to time, we may decide to deprecate an API that is particularly widely used. In these cases, we may decide to provide an extended deprecation period, at our discretion.

Testing

Running tests on latest cryptography right now (40), all tests pass

Additionally, a random sampling of 3p dependencies used in a random internal project seems to indicate that this is standard practice
image

Note - I have signed the CLA on behalf of my company, tied to my github username @markjm

@markjm
Copy link
Author

markjm commented Nov 6, 2024

Hi @adorton-adobe - thanks for maintaining the project. I have created a small PR which i think demonstrates a problem and fixes it. Please let me know if there is anything else youd like from me for validation or process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant