Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus metrics #527

Open
rockaut opened this issue Apr 6, 2021 · 2 comments
Open

prometheus metrics #527

rockaut opened this issue Apr 6, 2021 · 2 comments

Comments

@rockaut
Copy link

rockaut commented Apr 6, 2021

Anyone tried to add prometheus metrics/integration yet? Speaking anything against it?

@moorereason
Copy link
Collaborator

I assume you mean exposing a metrics HTTP endpoint in webhook for prometheus to scrape.

I haven't looked into it, but I've only toyed with prometheus in the past. Not super-familiar with it. I would be open to adding it, but we may need to agree on a proposal first. My initial questions:

  1. How would the user configure the feature? Do we need Support setting flags from the config file #326 first?
  2. What metrics should we export? Would that be configurable? What Caddy does looks interesting.

@rockaut
Copy link
Author

rockaut commented Apr 7, 2021

Yes Caddy came to my mind too. Personally I'm mostly interested in the error- and over-all-counts and less in the details like timings ... but that's just me.

On the configuration. I came across a lot of implementations where no config other than on/off were possible - thought small scale things. Most are using /metrics as the endpoint anyways and turning the feature on an off by providing a port or not through a flag. That said having config files could make things easier.

I've implemented prometheus metrics libraries mostly with python and my golang-fu isn't that strong but I'm hoping to help as much as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants