First release: finish testing and fix bugs

Author: jrogov

lib/file_cache.ex

@@ -14,7 +14,7 @@ defmodule FileCache do
   alias FileCache.Utils
   alias FileCache.Config
 
-  namespace_single_type = {:or, [{:in, [nil, :host]}, {:fun, 0}, :mfa]}
+  namespace_single_type = {:or, [{:in, [nil, :host]}, :string, {:fun, 0}, :mfa]}
   namespace_type = {:or, [namespace_single_type, {:list, namespace_single_type}]}
 
   @init_options_schema NimbleOptions.new!(
@@ -99,10 +99,6 @@ defmodule FileCache do
                        ttl: [
                          type: :pos_integer
                        ]
-                       # TODO: do we need it? what's the usecase?
-                       # owner: [
-                       #   type: :pid
-                       # ]
                      )
 
   defp validate_op_options!(opts) do

lib/file_cache/cleaner.ex

@@ -13,7 +13,7 @@ defmodule FileCache.Cleaner do
   @optional_callbacks name: 1
 
   defmacro __using__(opts) do
-    kind = opts[:kind]
+    kind = Keyword.fetch!(opts, :kind)
 
     quote do
       use GenServer

lib/file_cache/common.ex

@@ -6,19 +6,19 @@ defmodule FileCache.Common do
   alias FileCache.Config
   alias FileCache.Utils
 
-  def calculate_namespace(nil), do: ""
-
-  def calculate_namespace(many) when is_list(many) do
-    many
-    |> Enum.map(&do_calculate_namespace/1)
+  def calculate_namespace(namespace) do
+    namespace
+    |> List.wrap()
+    |> Enum.map(fn part -> validate_namespace_part(do_calculate_namespace(part)) end)
+    |> List.insert_at(0, "")
     |> Path.join()
   end
 
-  def calculate_namespace(other), do: do_calculate_namespace(other)
+  defp do_calculate_namespace(str) when is_binary(str), do: str
 
   defp do_calculate_namespace(:host) do
     {:ok, host} = :inet.gethostname()
-    host
+    IO.chardata_to_string(host)
   end
 
   defp do_calculate_namespace({m, f, a}), do: apply(m, f, a)

lib/file_cache/stale_cleaner.ex

@@ -1,7 +1,7 @@
 defmodule FileCache.StaleCleaner do
   @moduledoc false
 
-  use FileCache.Cleaner
+  use FileCache.Cleaner, kind: :stale
 
   alias FileCache.Config
   alias FileCache.Perm

lib/file_cache/temp.ex

@@ -16,7 +16,7 @@ defmodule FileCache.Temp do
     owner = Access.get(opts, :owner, self())
 
     filename =
-      "#{filename_prefix()}#{@sep}#{Utils.pid_to_string(owner)}#{@sep}#{:erlang.unique_integer()}_#{id}"
+      "#{filename_prefix()}#{@sep}#{Utils.pid_to_string(owner)}#{@sep}#{:erlang.unique_integer()}#{@sep}#{id}"
 
     Path.join(full_dir_path(cache_name), filename)
   end
@@ -76,7 +76,7 @@ defmodule FileCache.Temp do
   end
 
   defp parse_pid(pid_str) do
-    :erlang.list_to_pid('<#{pid_str}>')
+    {:ok, :erlang.list_to_pid('<#{pid_str}>')}
   rescue
     ArgumentError ->
       {:error, :bad_pid}