Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social icon for Bilibili #814

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

xen0n
Copy link
Contributor

@xen0n xen0n commented Mar 6, 2022

What does this PR change? What problem does it solve?

Adds social icon for bilibili which is a Chinese video service modeled after the Japanese niconico.

The icon is re-drawn by myself to use outlines (the simpleicons version is using fills, which appears to be 2.66px thick instead of the consistent 2px, as the original Bilibili version is 18x18 with 2px strokes converted to fills too).

Was the change discussed in an issue or in the Discussions before?

n/a

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

The icon is re-drawn by myself to use outlines, referring to the icon
used on bilibili.com and the simpleicons version (which all used fills).
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange merged commit 26315a9 into adityatelange:master Mar 11, 2022
@adityatelange adityatelange mentioned this pull request Mar 11, 2022
7 tasks
@xen0n xen0n deleted the social-icon-bilibili branch March 11, 2022 16:45
@adityatelange adityatelange added the icons Related to Icons label Mar 18, 2022
minyeamer pushed a commit to minyeamer/hugo-PaperMod that referenced this pull request Sep 16, 2022
The icon is re-drawn by myself to use outlines, referring to the icon
used on bilibili.com and the simpleicons version (which all used fills).
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
The icon is re-drawn by myself to use outlines, referring to the icon
used on bilibili.com and the simpleicons version (which all used fills).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons Related to Icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants