Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add title to the image tag in rss.xml #1105

Merged
merged 1 commit into from
Feb 4, 2023
Merged

add title to the image tag in rss.xml #1105

merged 1 commit into from
Feb 4, 2023

Conversation

k-yone
Copy link
Contributor

@k-yone k-yone commented Dec 12, 2022 •
edited
Loading

What does this PR change? What problem does it solve?

Was the change discussed in an issue or in the Discussions before?

  • I guess not?

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adityatelange
adityatelange reviewed Feb 4, 2023
View reviewed changes
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title described here https://cyber.harvard.edu/rss/rss.html#ltimagegtSubelementOfLtchannelgt

says:

<title> describes the image, it's used in the ALT attribute of the HTML tag when the channel is rendered in HTML.

Is not the site's title

@adityatelange
Copy link
Owner

Thing is we couldn't get the image's alt text which is inside the markdown with the images front matter variable.

@k-yone
Copy link
Contributor Author

k-yone commented Feb 4, 2023 •
edited
Loading

I see. You're right.
And the problem is, this <image> element is used to describe the whole website so there aren't any .md files that the user can declare the alt text for this image in a front matter.

The document says this <image> element is meant to be used as a link to the site, so personally, I think it's not completely wrong to use the site tile for the alt text, but it's nicer to add an option to the config to let users to set an alt text by themself.

@k-yone
Copy link
Contributor Author

k-yone commented Feb 4, 2023 •
edited
Loading

By the way, this <link> has to be a link to the website, not the image's url, right? I didn't notice.
https://github.com/adityatelange/hugo-PaperMod/pull/1105/files#diff-3fb10c6a0e1801f8c8a23a6858a8710151ae674fd98589294786ecb97e8220e2R23

@adityatelange
Copy link
Owner

By the way, this <link> has to be a link to the website, not the image's url, right? I didn't notice. https://github.com/adityatelange/hugo-PaperMod/pull/1105/files#diff-3fb10c6a0e1801f8c8a23a6858a8710151ae674fd98589294786ecb97e8220e2R23

Nope, the link is for each image provided by user.

@adityatelange
Copy link
Owner

@k-yone I was wrong. It is used to describe the whole website. We can merge.

@adityatelange
Copy link
Owner

adityatelange commented Feb 4, 2023 •
edited
Loading

For RSS feeds present inside a section we'll have to add something, but that is a different topic to be discussed.
ex. https://adityatelange.github.io/hugo-PaperMod/posts/papermod/index.xml

@adityatelange adityatelange merged commit 4d42965 into adityatelange:master Feb 4, 2023
Nicceboy added a commit to Nicceboy/hugo-PaperMod that referenced this pull request Feb 11, 2023
@Nicceboy @adityatelange
@eisraeli @niturk @EssaAlshammri @igorr0driguez @fobo66 @MacKarp @Merovius @theJoshMuller @raisilhamn @Natooz @JingBh @k-yone @alswl
Update from origin (#1)
85e5774 
* Fix multi-line anchor tags not highlighted/underlined.

fixes: adityatelange#1107

* Update Hebrew translation (adityatelange#1104)

Signed-off-by: Eran Israeli <eisraeli@redhat.com>

* Improve Turkish Translation tr.yaml (adityatelange#1098)

* update arabic pagination translation (adityatelange#1137)

* PT translation updated (adityatelange#1124)

Signed-off-by: igorr0driguez <42983358+igorr0driguez@users.noreply.github.com>

* Added Belarusian translations i18n/be.yaml (adityatelange#1144)

* updated Polish translation (adityatelange#1148)

* Add Tumblr Icon (adityatelange#1115)

* Add TryHackMe Icon (adityatelange#1113)

from Simple Icons https://github.com/simple-icons/simple-icons/blob/develop/icons/tryhackme.svg

* Add codeforces icon (adityatelange#1092)

From https://github.com/simple-icons/simple-icons

* Google scholar svg icon fixed, now unfilled curved line (adityatelange#1064)

* Add netease cloud music icon (adityatelange#1093)

* Add title to the image tag in rss.xml (adityatelange#1105)

Ref: https://cyber.harvard.edu/rss/rss.html#ltimagegtSubelementOfLtchannelgt

* Add douban and zhihu icon (adityatelange#1084)

* Update README

---------

Signed-off-by: Eran Israeli <eisraeli@redhat.com>
Signed-off-by: igorr0driguez <42983358+igorr0driguez@users.noreply.github.com>
Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
Co-authored-by: Eran Israeli <eisraeli@redhat.com>
Co-authored-by: Nikita <3787035+niturk@users.noreply.github.com>
Co-authored-by: Essa Alshammri <essa.alshammri@gmail.com>
Co-authored-by: Igor Rodriguez <42983358+igorr0driguez@users.noreply.github.com>
Co-authored-by: Andrey Mukamolov <4471821+fobo66@users.noreply.github.com>
Co-authored-by: Karpfly <karpfly@gmail.com>
Co-authored-by: Axel Wagner <mail@merovius.de>
Co-authored-by: Josh Müller <39825267+theJoshMuller@users.noreply.github.com>
Co-authored-by: rais ilham <rais.ilham.nustara-2020@fst.unair.ac.id>
Co-authored-by: Nathan Fradet <56734983+Natooz@users.noreply.github.com>
Co-authored-by: Bohao Jing <jingbohao@yeah.net>
Co-authored-by: k-yone <9046344+k-yone@users.noreply.github.com>
Co-authored-by: Jingchao <alswlx@gmail.com>
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
@k-yone
Add title to the image tag in rss.xml (adityatelange#1105)
b459064 
Ref: https://cyber.harvard.edu/rss/rss.html#ltimagegtSubelementOfLtchannelgt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-yone @adityatelange