feat: allow bulk edit of verify and review #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's not possible to bulk edit any reports that have the "needs review" flag set. This MR addresses this and shows you a warning (and then the backend throws an error) if you try to save an invalid combination of verify and review.
StephanH90
added
feature
derrabauke
approved these changes
Jul 8, 2025
|
@trowik I need to take a look at the failing test. I had a quick look right now but I didn't understand why the data attribute that is set in the test is not received by the |
winged
reviewed
Jul 8, 2025
| @@ -251,11 +251,24 @@ def bulk(self, request): | |||
|
|
|||
| fields["verified_by"] = (verified and user) or None | |||
|
|
|||
| if fields.get("review") or any(queryset.values_list("review", flat=True)): | |||
| if ( | |||
| any(queryset.values_list("review", flat=True)) | |||
There was a problem hiding this comment.
Suggested change
| any(queryset.values_list("review", flat=True)) | |
| queryset.filter(review=True).exists() |
| if ( | ||
| verified is None | ||
| and fields.get("review") | ||
| and any(queryset.values_list("verified_by", flat=True)) |
There was a problem hiding this comment.
Suggested change
| and any(queryset.values_list("verified_by", flat=True)) | |
| and queryset.filter(verified_by__isnull=False).exists() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to bulk edit any reports that have the "needs review" flag set. This MR addresses this and shows you a warning (and then the backend throws an error) if you try to save an invalid combination of verify and review.