This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
I think should check value before set it to bits. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve not check weather the value greater than 0x1f. may be that is a bug.
|
This looks like a nice improvement. Can you add a test that would have failed without the check? We aren't sure that the additions you made to the test would have failed even with the old code. |
… have not check the value. and I think maybe change the 0x1F depends on RegisterSet.REGISTER would be better.
|
I write back the RegisterSet, now the test would be FAIL, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegisterSet class set and updateIfGreater method update value, but have not check weather the value greater than 0x1f.
may be that is a bug.