Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: adcontextprotocol/adcp-client-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.5.0
Choose a base ref
...
head repository: adcontextprotocol/adcp-client-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.6.0
Choose a head ref
  • 2 commits
  • 8 files changed
  • 3 contributors

Commits on Nov 19, 2025

  1. feat: complete semantic alias coverage for discriminated unions (#63) 

    * feat: add semantic aliases for PublisherProperties discriminated union

Add user-friendly type aliases for the PublisherProperties discriminated
union variants to improve developer experience and avoid direct imports
from generated_poc.

Changes:
- Add PublisherPropertiesAll (selection_type='all')
- Add PublisherPropertiesById (selection_type='by_id')
- Add PublisherPropertiesByTag (selection_type='by_tag')
- Export PropertyId and PropertyTag types for use with the variants
- Update all export paths (aliases.py, types/__init__.py, __init__.py)
- Add comprehensive tests covering imports, type checking, and instantiation

These aliases follow the established pattern for other discriminated unions
(PreviewRender, VastAsset, etc.) and provide clear, semantic names that
match the spec's discriminator values.

Example usage:
```python
from adcp import PublisherPropertiesByTag, PropertyTag

props = PublisherPropertiesByTag(
    publisher_domain="example.com",
    selection_type="by_tag",
    property_tags=[PropertyTag("premium"), PropertyTag("video")]
)
```

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat: add semantic aliases for Deployment and Destination discriminated unions

Complete the semantic aliasing coverage by adding aliases for signal
deployment and destination types used in GetSignalsResponse.

Changes:
- Add PlatformDeployment (Deployment1, type='platform')
- Add AgentDeployment (Deployment2, type='agent')
- Add PlatformDestination (Destination1, type='platform')
- Add AgentDestination (Destination2, type='agent')
- Update all export paths (aliases.py, __init__.py)
- Add 7 comprehensive tests covering imports, type checking, and instantiation

These aliases complete coverage of all user-facing discriminated unions
in the AdCP SDK. Users no longer need to import numbered types or reach
into generated_poc for any common operations.

Example usage:
```python
from adcp import PlatformDeployment, AgentDestination

deployment = PlatformDeployment(
    type="platform",
    platform="the-trade-desk",
    is_live=True
)

destination = AgentDestination(
    type="agent",
    agent_url="https://agent.example.com"
)
```

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* docs: document comprehensive semantic aliasing strategy

Add detailed documentation on:
- Complete coverage of all 30 user-facing discriminated union aliases
- List of 15 internal types that don't need aliases
- Five-strategy approach to prevent numbered type usage:
  1. Complete aliasing coverage checklist
  2. Automated detection script (check_missing_aliases.py)
  3. CI enforcement in workflows
  4. Import linting with pre-commit hooks
  5. Type regeneration workflow documentation

This ensures downstream users never need to import from generated_poc
or use numbered types, maintaining a clean and stable public API.

The documentation includes:
- Updated list of all current semantic aliases
- Guidelines for when to alias vs skip
- Bash commands for auditing numbered types
- Python script templates for automation
- CI/CD integration examples

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* style: fix import sorting in aliases.py

---------

Co-authored-by: Claude <noreply@anthropic.com>
    @bokelley @claude
    bokelley and claude authored Nov 19, 2025
    Configuration menu
    Copy the full SHA
    ab49c98 View commit details
    Browse the repository at this point in the history

  2. chore(main): release 2.6.0 (#64) 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] authored Nov 19, 2025
    Configuration menu
    Copy the full SHA
    9f63373 View commit details
    Browse the repository at this point in the history
Loading