Skip to content

Commit 45350d1

Browse files
committed
fix: resolve import sorting lint error in generated _ergonomic.py
- Remove inline comments that broke import block sorting - Fix generate_ergonomic_coercion.py to not emit comments in import block
1 parent 73ea15b commit 45350d1

File tree

2 files changed

+14
-19
lines changed

2 files changed

+14
-19
lines changed

scripts/generate_ergonomic_coercion.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,6 @@ def generate_code() -> str:
326326
' coerce_to_model,',
327327
')',
328328
'',
329-
'# Import types that need coercion',
330329
]
331330

332331
# Add core imports
@@ -357,7 +356,6 @@ def generate_code() -> str:
357356
lines.append(')')
358357

359358
# Add response type imports
360-
lines.append('# Response types')
361359
lines.append('from adcp.types.generated_poc.media_buy.create_media_buy_response import (')
362360
lines.append(' CreateMediaBuyResponse1,')
363361
lines.append(')')

src/adcp/types/_ergonomic.py

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@
3939
coerce_to_enum_list,
4040
coerce_to_model,
4141
)
42-
43-
# Import types that need coercion
4442
from adcp.types.generated_poc.core.context import ContextObject
4543
from adcp.types.generated_poc.core.creative_asset import CreativeAsset
4644
from adcp.types.generated_poc.core.creative_assignment import CreativeAssignment
@@ -57,21 +55,6 @@
5755
from adcp.types.generated_poc.media_buy.create_media_buy_request import (
5856
CreateMediaBuyRequest,
5957
)
60-
from adcp.types.generated_poc.media_buy.get_products_request import GetProductsRequest
61-
from adcp.types.generated_poc.media_buy.list_creative_formats_request import (
62-
ListCreativeFormatsRequest,
63-
)
64-
from adcp.types.generated_poc.media_buy.list_creatives_request import (
65-
FieldModel,
66-
ListCreativesRequest,
67-
Sort,
68-
)
69-
from adcp.types.generated_poc.media_buy.package_request import PackageRequest
70-
from adcp.types.generated_poc.media_buy.update_media_buy_request import (
71-
Packages,
72-
Packages1,
73-
)
74-
# Response types
7558
from adcp.types.generated_poc.media_buy.create_media_buy_response import (
7659
CreateMediaBuyResponse1,
7760
)
@@ -80,15 +63,29 @@
8063
MediaBuyDelivery,
8164
NotificationType,
8265
)
66+
from adcp.types.generated_poc.media_buy.get_products_request import GetProductsRequest
8367
from adcp.types.generated_poc.media_buy.get_products_response import GetProductsResponse
68+
from adcp.types.generated_poc.media_buy.list_creative_formats_request import (
69+
ListCreativeFormatsRequest,
70+
)
8471
from adcp.types.generated_poc.media_buy.list_creative_formats_response import (
8572
CreativeAgent,
8673
ListCreativeFormatsResponse,
8774
)
75+
from adcp.types.generated_poc.media_buy.list_creatives_request import (
76+
FieldModel,
77+
ListCreativesRequest,
78+
Sort,
79+
)
8880
from adcp.types.generated_poc.media_buy.list_creatives_response import (
8981
Creative,
9082
ListCreativesResponse,
9183
)
84+
from adcp.types.generated_poc.media_buy.package_request import PackageRequest
85+
from adcp.types.generated_poc.media_buy.update_media_buy_request import (
86+
Packages,
87+
Packages1,
88+
)
9289

9390

9491
def _apply_coercion() -> None:

0 commit comments

Comments
 (0)