Skip to content
This repository was archived by the owner on Feb 21, 2021. It is now read-only.

Commit 8dbe28c

Browse files
committed
Fixed #267 - Missing integration changes for filterState
1 parent 45326f7 commit 8dbe28c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

lib/csp.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ browser.webRequest.onHeadersReceived.addListener(details =>
7575
url: details.url, type: "CSP", docDomain: hostname,
7676
specificOnly
7777
}, cspMatch);
78-
filterNotifier.emit("filter.hitCount", cspMatch, 0, 0, [details.tabId]);
78+
recordBlockedRequest(cspMatch, [details.tabId]);
7979

8080
details.responseHeaders.push({
8181
name: "Content-Security-Policy",

lib/filterConfiguration.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {Subscription, DownloadableSubscription,
3333
const {showOptions} = require("./options");
3434
const {recommendations} = require("../adblockpluscore/lib/recommendations");
3535
const {allowlistedDomainRegexp} = require("./allowlisting");
36+
const {filterState} = require("../adblockpluscore/lib/filterState");
3637

3738
function convertObject(keys, obj)
3839
{
@@ -326,7 +327,7 @@ port.on("filters.importRaw", (message, sender) =>
326327
for (let filter of filters)
327328
{
328329
if (isActiveFilter(filter))
329-
filter.disabled = false;
330+
filterState.setEnabled(filter.text, true);
330331

331332
filterStorage.addFilter(filter);
332333
addedFilters.add(filter.text);
@@ -396,8 +397,7 @@ port.on("filters.replace", (message, sender) =>
396397
*/
397398
port.on("filters.toggle", (message, sender) =>
398399
{
399-
let filter = Filter.fromText(message.text);
400-
filter.disabled = message.disabled;
400+
filterState.setEnabled(message.text, !message.disabled);
401401
});
402402

403403
/**
@@ -485,7 +485,7 @@ port.on("subscriptions.get", (message, sender) =>
485485
{
486486
subscription.disabledFilters =
487487
Array.from(s.filterText(), Filter.fromText)
488-
.filter(f => isActiveFilter(f) && f.disabled)
488+
.filter(f => isActiveFilter(f) && !filterState.isEnabled(f.text))
489489
.map(f => f.text);
490490
}
491491
subscriptions.push(subscription);
@@ -578,7 +578,7 @@ function filtersAdd(text)
578578
if (filter)
579579
{
580580
if (isActiveFilter(filter))
581-
filter.disabled = false;
581+
filterState.setEnabled(text, true);
582582
filterStorage.addFilter(filter);
583583
}
584584

0 commit comments

Comments
 (0)